Check minimal version of Rust that compiles #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The minimum version for the updated My current thinking is to remove the |
|
The current version of miniz_oxide works with 1.56.0 as of now if I test it on it's own locally though I don't want to give any guarantees that it will stay at that. It looks like you may need to pin some other crates to older versions to make flate2 work with that version though judging by the CI build results. |
|
Ah it's |
jongiddy
force-pushed
the
test-minimal-version
branch
2 times, most recently
from
cc5a458
to
8475fed
Compare
|
Changed the CI workflow to only test that code builds, without running the tests. |
jongiddy
force-pushed
the
test-minimal-version
branch
from
8475fed
to
78bbc72
Compare
Byron
requested changes
Aug 17, 2024
There was a problem hiding this comment.
Thanks a lot for making clearer the defacto way the MSRV was handled.
I'd also hope that adding the rust-version can't break anyone. In theory, those who use even more ancient compiler versions will benefit from those not respecting that field yet. So it should be safe especially with a value as low as that.
There is just one improvement that I think could be made to the MSRV paragraph, which would have helped me to understand it more quickly.
README.md
Outdated
|
|
||
| Older stables may work, but failures may not be treated as a `flate2` bug. | ||
|
|
||
| The `Cargo.toml` file specifies a minimum version for which builds passed at some point. |
There was a problem hiding this comment.
Suggested change
| The `Cargo.toml` file specifies a minimum version for which builds passed at some point. | |
| The `Cargo.toml` file specifies a minimum version for which builds passed at some point using the `rust-version` field. |
There was a problem hiding this comment.
Since 'minimum version' is really the rust-version field, I wonder if that name should rather be used to reduce the level of abstraction.
Specify a minimum version of the Rust compiler that successfully builds the crate. This allows us to be aware if the minimal version increases and to avoid issues such as rust-lang#370 The minimum version is a best-effort measured value and is different to the MSRV which is a support guarantee. The minimum version can be incremented by a PR in order to pass tests, as long as the MSRV holds. When the minimum version increases, the next release should be a minor version, to allow any affected users to pin to a previous minor version.
jongiddy
force-pushed
the
test-minimal-version
branch
from
78bbc72
to
140b285
Compare
Byron
reviewed
Aug 18, 2024
| @@ -7,8 +7,7 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| # I don't really understand the build matrix here... | |||
| build: [stable, beta, nightly, macos, windows, mingw] | |||
| build: [stable, beta, nightly, minimal, macos, windows, mingw] | |||
There was a problem hiding this comment.
CI now fails on main, and I have a feeling that this entry might be the cause of it?
It's surprising that it didn't fail CI before.
In any case, your help for a fix will be welcome.
|
Oh wow, CI should complain more noisily if that happens! #422 should be the fix. |
renovate bot
referenced
this pull request
in oxc-project/oxc
Aug 26, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flate2](https://togithub.com/rust-lang/flate2-rs) | workspace.dependencies | patch | `1.0.31` -> `1.0.33` | | [prettyplease](https://togithub.com/dtolnay/prettyplease) | workspace.dependencies | patch | `0.2.20` -> `0.2.22` | | [quote](https://togithub.com/dtolnay/quote) | workspace.dependencies | patch | `1.0.36` -> `1.0.37` | | [serde](https://serde.rs) ([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies | patch | `1.0.208` -> `1.0.209` | | [serde_json](https://togithub.com/serde-rs/json) | workspace.dependencies | patch | `1.0.125` -> `1.0.127` | --- ### Release Notes <details> <summary>rust-lang/flate2-rs (flate2)</summary> ### [`v1.0.33`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.33): - fix minimal manifest versions [Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.32...1.0.33) #### What's Changed - Fix msrv: Run msrv checks with minimal versions by [@​NobodyXu](https://togithub.com/NobodyXu) in [https://github.com/rust-lang/flate2-rs/pull/425](https://togithub.com/rust-lang/flate2-rs/pull/425) #### New Contributors - [@​NobodyXu](https://togithub.com/NobodyXu) made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/425](https://togithub.com/rust-lang/flate2-rs/pull/425) **Full Changelog**: rust-lang/flate2-rs@1.0.32...1.0.33 ### [`v1.0.32`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.32): - turn panic into error [Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.31...1.0.32) #### What's Changed ##### Fix - Return error instead of packing on Z_MEM_ERROR by [@​crazymerlyn](https://togithub.com/crazymerlyn) in [https://github.com/rust-lang/flate2-rs/pull/423](https://togithub.com/rust-lang/flate2-rs/pull/423) ##### Other - prepare new release by [@​Byron](https://togithub.com/Byron) in [https://github.com/rust-lang/flate2-rs/pull/416](https://togithub.com/rust-lang/flate2-rs/pull/416) - update miniz_oxide dependency to 0.8.x by [@​oyvindln](https://togithub.com/oyvindln) in [https://github.com/rust-lang/flate2-rs/pull/420](https://togithub.com/rust-lang/flate2-rs/pull/420) - update maintenance guide with recent news by [@​Byron](https://togithub.com/Byron) in [https://github.com/rust-lang/flate2-rs/pull/419](https://togithub.com/rust-lang/flate2-rs/pull/419) - Check minimal version of Rust that compiles by [@​jongiddy](https://togithub.com/jongiddy) in [https://github.com/rust-lang/flate2-rs/pull/421](https://togithub.com/rust-lang/flate2-rs/pull/421) - Remove non-existent build in CI by [@​jongiddy](https://togithub.com/jongiddy) in [https://github.com/rust-lang/flate2-rs/pull/422](https://togithub.com/rust-lang/flate2-rs/pull/422) #### New Contributors - [@​crazymerlyn](https://togithub.com/crazymerlyn) made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/423](https://togithub.com/rust-lang/flate2-rs/pull/423) **Full Changelog**: rust-lang/flate2-rs@1.0.31...1.0.32 </details> <details> <summary>dtolnay/prettyplease (prettyplease)</summary> ### [`v0.2.22`](https://togithub.com/dtolnay/prettyplease/releases/tag/0.2.22) [Compare Source](https://togithub.com/dtolnay/prettyplease/compare/0.2.21...0.2.22) - Support formatting precise capture `use<>` syntax ([#​80](https://togithub.com/dtolnay/prettyplease/issues/80)) ### [`v0.2.21`](https://togithub.com/dtolnay/prettyplease/releases/tag/0.2.21) [Compare Source](https://togithub.com/dtolnay/prettyplease/compare/0.2.20...0.2.21) - Support formatting tail-call `become` expressions ([#​79](https://togithub.com/dtolnay/prettyplease/issues/79)) </details> <details> <summary>dtolnay/quote (quote)</summary> ### [`v1.0.37`](https://togithub.com/dtolnay/quote/releases/tag/1.0.37) [Compare Source](https://togithub.com/dtolnay/quote/compare/1.0.36...1.0.37) - Implement ToTokens for CStr and CString ([#​283](https://togithub.com/dtolnay/quote/issues/283)) </details> <details> <summary>serde-rs/serde (serde)</summary> ### [`v1.0.209`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.209) [Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.208...v1.0.209) - Fix deserialization of empty structs and empty tuples inside of untagged enums ([#​2805](https://togithub.com/serde-rs/serde/issues/2805), thanks [@​Mingun](https://togithub.com/Mingun)) </details> <details> <summary>serde-rs/json (serde_json)</summary> ### [`v1.0.127`](https://togithub.com/serde-rs/json/releases/tag/1.0.127) [Compare Source](https://togithub.com/serde-rs/json/compare/1.0.126...1.0.127) - Add more removal methods to OccupiedEntry ([#​1179](https://togithub.com/serde-rs/json/issues/1179), thanks [@​GREsau](https://togithub.com/GREsau)) ### [`v1.0.126`](https://togithub.com/serde-rs/json/releases/tag/1.0.126) [Compare Source](https://togithub.com/serde-rs/json/compare/1.0.125...1.0.126) - Improve string parsing on targets that use 32-bit pointers but also have fast 64-bit integer arithmetic, such as aarch64-unknown-linux-gnu_ilp32 and x86\_64-unknown-linux-gnux32 ([#​1182](https://togithub.com/serde-rs/json/issues/1182), thanks [@​CryZe](https://togithub.com/CryZe)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10am on monday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/oxc-project/oxc). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify a minimum version of the Rust compiler that successfully builds the crate. This allows us to be aware if the minimal version increases and to avoid issues such as #370
The minimum version is a best-effort measured value and is different to the MSRV which is a support guarantee. The minimum version can be incremented by a PR in order to pass tests, as long as the MSRV holds. When the minimum version increases, the next release should be a minor version, to allow any affected users to pin to a previous minor version.